[pull] main from MetaMask:main#396
Merged
Merged
Conversation
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
The purpose of this PR is to slow down the swipe to reveal the
Predictions tab and make the $48.16 balance assertion run on all
platforms in the claim positions test.
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry:
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Slow the swipe to the Predictions tab, assert `$48.16` on all
platforms, and remove an unnecessary delay in the withdraw test.
>
> - **E2E Tests**:
> - **Activities View** (`e2e/pages/Transactions/ActivitiesView.ts`):
> - Slow down swipe to reveal `Predictions` tab by adding `speed:
'slow'` to `Gestures.swipe`.
> - **Predict Claim Positions**
(`e2e/specs/predict/predict-claim-positions.spec.ts`):
> - Always assert final balance `$48.16` (remove iOS-only condition).
> - **Predict Withdraw** (`e2e/specs/predict/predict-withdraw.spec.ts`):
> - Remove unnecessary 9s delay; keep TODO for withdraw flow.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
3376983. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Update nav options Update Signup Update ConfirmEmail Update ConfirmPhoneNumber Update Address Update VerifyIdentity Update PersonalDetails Update KYC success and failure <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Update card onboarding flow according to new design [CARD-213](https://consensyssoftware.atlassian.net/browse/CARD-213) [CARD-216](https://consensyssoftware.atlassian.net/browse/CARD-216) [CARD-217](https://consensyssoftware.atlassian.net/browse/CARD-217) [CARD-220](https://consensyssoftware.atlassian.net/browse/CARD-220) Half of [CARD-221](https://consensyssoftware.atlassian.net/browse/CARD-221) since address search and autocompletion requires a new library [CARD-222](https://consensyssoftware.atlassian.net/browse/CARD-222) [CARD-223](https://consensyssoftware.atlassian.net/browse/CARD-223) [CARD-224](https://consensyssoftware.atlassian.net/browse/CARD-224) <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Update card onboarding flow according to new design ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-05 at 14 10 51" src="https://github.com/user-attachments/assets/843d0a66-ddc1-40d4-90ff-bdf530166cc9" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-05 at 14 10 56" src="https://github.com/user-attachments/assets/84705009-9737-4d12-a0bd-51cfe7fd6054" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-05 at 14 12 07" src="https://github.com/user-attachments/assets/945ed24a-1e8a-42b0-893f-2108afe392a2" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-08 at 10 36 23" src="https://github.com/user-attachments/assets/4ec93477-c5f2-42ad-96ee-bf945f6a2993" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-05 at 14 15 16" src="https://github.com/user-attachments/assets/f45008bd-08b7-48f1-968b-a8951cdaf5e2" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-08 at 10 42 57" src="https://github.com/user-attachments/assets/89b97c4c-dfc5-4efe-b28b-ff08f6624a38" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-09 at 12 11 02" src="https://github.com/user-attachments/assets/077d8ef5-96aa-4131-a441-f63ac565b8f5" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-05 at 14 39 46" src="https://github.com/user-attachments/assets/71cc5661-0c51-4720-a430-a0ac45e80bf2" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-05 at 14 34 16" src="https://github.com/user-attachments/assets/a2d3d7d2-0b2d-4fc6-b35a-b26ea1489773" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-05 at 14 34 28" src="https://github.com/user-attachments/assets/ffac8399-2485-4abc-b819-df2bed108dd0" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-08 at 10 44 00" src="https://github.com/user-attachments/assets/9133d701-76c4-4922-a6f9-3c08ea2b68af" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-05 at 14 35 40" src="https://github.com/user-attachments/assets/d4801d92-f63b-41b7-9ff8-b9709070d9cd" /> <img width="1179" height="2556" alt="Simulator Screenshot - E2E Test - 2025-12-05 at 14 35 50" src="https://github.com/user-attachments/assets/23e81a3f-23e8-4daa-9709-4d10ccdae0f9" /> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [CARD-213]: https://consensyssoftware.atlassian.net/browse/CARD-213?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [CARD-216]: https://consensyssoftware.atlassian.net/browse/CARD-216?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [CARD-217]: https://consensyssoftware.atlassian.net/browse/CARD-217?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [CARD-220]: https://consensyssoftware.atlassian.net/browse/CARD-220?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [CARD-221]: https://consensyssoftware.atlassian.net/browse/CARD-221?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [CARD-222]: https://consensyssoftware.atlassian.net/browse/CARD-222?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [CARD-223]: https://consensyssoftware.atlassian.net/browse/CARD-223?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [CARD-224]: https://consensyssoftware.atlassian.net/browse/CARD-224?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Redesigns the Card onboarding and welcome experiences, updates navigation flow and copy, modernizes form inputs/UX, and adds country flag utility with comprehensive test updates. > > - **UI/UX**: > - **Welcome Screen**: Rebuilt `CardWelcome` with responsive styles, new imagery, CTA (“Apply now”), “Not now” to `Routes.WALLET.HOME`, and metrics. > - **OnboardingStep Layout**: Updated typography and removed legacy mockup image; adjusted title/description styling. > - **Screens**: Refreshed `VerifyIdentity`, `ValidatingKYC` (image, description, close button), `KYCFailed` (image, close to Home), and `Complete` (new content and confirm button). > - **Navigation/Flow**: > - Added `Routes.CARD.ONBOARDING.COMPLETE`; initial-route logic now finishes at `COMPLETE` (removed mailing-step branching). > - `ValidatingKYC` now resets to `COMPLETE` on success or `KYC_FAILED` on reject; KYC modal close goes to `PERSONAL_DETAILS`. > - Default nav options simplified (back-only), welcome header hidden; new `PersonalDetailsNavigationOptions` back to `VERIFY_IDENTITY`. > - **Forms/Inputs**: > - `ConfirmEmail`/`ConfirmPhoneNumber`: replaced code cells with `TextField`, numeric filtering, auto-submit on 6 digits, revised resend UX (“Didn’t receive… Resend”). > - `SetPhoneNumber`: country selector shows flag and `ISO-CC` value; updated legal/copy. > - `PhysicalAddress`: trimmed consents to e-sign only, added country select (read-only), assumes same mailing, navigates to `VALIDATING_KYC` when registered; action/errors moved below button. > - `PersonalDetails` and `SignUp`: copy tweaks, validation improvements (success icons, disabled logic, reset navigation on continue). > - **Utilities**: > - Added `countryCodeToFlag` helper with unit tests. > - **i18n**: > - Overhauled onboarding copy/labels/flows across locales. > - **Tests**: > - Broad updates to align with new UI, flows, metrics, and navigation; added new tests for flags, resend behavior, and navigation resets. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d314e6c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )